Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unsupported VideoCodecContext.gop_size.__get__ method #1255

Closed
wants to merge 1 commit into from

Conversation

JoeSchiff
Copy link
Contributor

Fix this issue.

I believe ffmpeg does not support getting the GOP size, therefore the returned value is incorrect.

This is my first pull request so let me know if I'm doing it wrong.

@jlaine
Copy link
Member

jlaine commented Jan 8, 2024

I don't think this is the right approach, see my comments in #1254

@JoeSchiff JoeSchiff closed this Jan 8, 2024
@JoeSchiff JoeSchiff deleted the remove_gop_size_getter branch January 22, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect value returned by VideoCodecContext.gop_size
2 participants